Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decryptor: recover from SOPS store panic #691

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jul 1, 2022

Based on user reports, there seems to be a small chance for the
underlying SOPS store implementation to panic when a user provides input
and/or output format instructions which do not actually match the type
of the file. Recover from this to ensure continuity of operations.

@hiddeco hiddeco force-pushed the sops-recover-store-panic branch 3 times, most recently from 5aee735 to 4276e37 Compare July 1, 2022 07:53
@hiddeco hiddeco added the area/sops SOPS related issues and pull requests label Jul 1, 2022
@hiddeco
Copy link
Member Author

hiddeco commented Jul 1, 2022

I have been unable to come up with a test case which actually reproduces the issue, due to not having a clear view of the environment of the user which reported it. But this catches things at the right point for any panic that may occur while working with the SOPS store, which should resolve things based on the stack trace that was shared.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

@stefanprodan stefanprodan mentioned this pull request Jul 13, 2022
Based on user reports, there seems to be a small chance for the
underlying SOPS store implementation to panic when a user provides input
and/or output format instructions which do not actually match the type
of the file. Recover from this to ensure continuity of operations.

Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco marked this pull request as ready for review July 13, 2022 13:51
@hiddeco hiddeco merged commit 1c661ad into main Jul 13, 2022
@hiddeco hiddeco deleted the sops-recover-store-panic branch July 13, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sops SOPS related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants