Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Extract generator to internal package #740

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Refactor: Extract generator to internal package #740

merged 1 commit into from
Oct 7, 2022

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 7, 2022 •
edited
Loading

Move the manifests generation logic and related unit tests from controllers to internal/generator.

Ref: #663

@stefanprodan
Refactor: Extract generator to internal package
731188e 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added this to the GA milestone Oct 7, 2022
@stefanprodan stefanprodan merged commit 3086ae4 into main Oct 7, 2022
@stefanprodan stefanprodan deleted the refactor-generator branch October 7, 2022 10:32
@stefanprodan stefanprodan modified the milestones: GA, Bootstrap GA Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

@pjbgf pjbgf Awaiting requested review from pjbgf

Assignees
No one assigned
Labels
None yet
Projects
Maintainers' Focus
Archived in project
Milestone
Bootstrap GA
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco