Refactor: Remove docs which overlap with Flux website #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Oct 19, 2022
stefanprodan
force-pushed
the
refact-docs
branch
from
1153cf1
to
f98d079
Compare
hiddeco
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
I do not think that this closes #664, as it is still structured in a different way than the new spec documentation around sources (e.g. "Writing a Kustomization spec" like https://github.com/fluxcd/source-controller/blob/main/docs/spec/v1beta2/buckets.md#writing-a-bucket-spec, and explicit mention of fields and their behavior).
Comment on lines
+28
to
+29
| - detects drift between the desired and state and cluster state | ||
| - corrects drift by patching objects with Kubernetes server-side apply |
docs/spec/v1beta2/kustomization.md
Outdated
| > Kubernetes manifests and configuration files referenced in the kustomization.yaml. | ||
| > If your Git repository or S3 bucket contains only plain manifests, | ||
| > then a kustomization.yaml will be automatically generated. | ||
| > **Note** that if the source contains a `kustomization.yaml` file, then it should also contain |
There was a problem hiding this comment.
In the "new way of writing specs", I think notes have the format of:
**Note:** If the resource contains ...
opposed to putting them in a quote block.
It doesn't, I just added a ref to it. |
|
Ah, absolutely my bad for misreading. |
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
refact-docs
branch
from
f98d079
to
3e935d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Ref: #663 #664