Add object kind to messages #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
|
Should we mimic the current implementation of the git notifications? In those providers the kind is already included and we lowercase all of the text. |
@stefanprodan What do you think? We should definitely maintain a consistent format |
|
Yes the kind should be lowercase, this is also consistent with kustomize-controller apply logs. |
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
stefanprodan
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the object kind of the source of the notification to the message.
The format is
<kind>/<name>.<namespaces>Fixes #120
Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com