Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic webhook receiver for HMAC signing #127

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

somtochiama
Copy link
Member

Fixes #99

@stefanprodan stefanprodan changed the title Generic signing Add generic webhook receiver for HMAC signing Jan 20, 2021
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
HarborReceiver string = "harbor"
DockerHubReceiver string = "dockerhub"
QuayReceiver string = "quay"
GCRReceiver string = "gcr"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some spacing

}

s.logger.Info(
"handling event from generic wehbook",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"handling event from generic wehbook",
"handling event from generic-hmac wehbook",

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit 6167e93 into fluxcd:main Jan 21, 2021
@somtochiama somtochiama deleted the generic-signing branch March 3, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow signing of generic webhook provider requests
2 participants