Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opsgenie provider #252

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

Alan01252
Copy link
Contributor

This pull request adds opsgenie as a provider and allows extra metadata to be configured against an alert.
This is useful when you're running multiple clusters and want to distinguish where the alert has come from ( for example dev/staging/prod environments )

Opsgenie has been added as a receiver and this has been tested locally.
Opsgenie makes use of the extra metadata in order to route requests to appropriate slack channels etc.

api/v1beta1/alert_types.go Outdated Show resolved Hide resolved
@Alan01252
Copy link
Contributor Author

As discussed I've removed the extraMetadata functionality and confirmed summary field appears in opsgenie if added to the Alert manifest.

image

@Alan01252 Alan01252 changed the title Add opsgenie provider and additional metadata Add opsgenie provider Oct 6, 2021
@Alan01252 Alan01252 force-pushed the feature/OpsAndMeta branch 2 times, most recently from 7ab448d to 37de0d0 Compare October 6, 2021 09:50
@Alan01252 Alan01252 force-pushed the feature/OpsAndMeta branch 3 times, most recently from 05cd5da to 0709697 Compare October 6, 2021 10:57
@Alan01252
Copy link
Contributor Author

Alan01252 commented Oct 6, 2021

Interesting this is failing. I was debating whether I need to check-in the output of make manifest but this causes a rather larger diff than I was expecting so I assumed I was missing something. I could just manually add opsgenie to the crd which would resolve this..

@stefanprodan
Copy link
Member

You need to run make generate api-docs and commit the changes.

@Alan01252
Copy link
Contributor Author

Alan01252 commented Oct 6, 2021

You need to run make generate api-docs and commit the changes.

There are no changes to the API docs when running that command, the build was failing because of a diff in the CRD docs. If I run make manifests locally I get a much larger diff than expected.

The current commit should be all that's required to make the build pass.

image

Signed-off-by: Alan Hollis <me@alanhollis.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Alan01252 🏅

@stefanprodan stefanprodan added area/alerting Alerting related issues and PRs enhancement New feature or request labels Oct 8, 2021
@stefanprodan stefanprodan merged commit 0e55a23 into fluxcd:main Oct 8, 2021
@Alan01252 Alan01252 deleted the feature/OpsAndMeta branch October 8, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants