Add metadata key for holding an arbitrary identification token

[matheuscscp]

Part of the PRs for fluxcd/helm-controller#678 alongside fluxcd/helm-controller#681 and fluxcd/notification-controller#518

[hiddeco]

Have discussed this more with @darkowlzz. How we think this should work is that it would introduce a new token key. The value of this key can be arbitrary (e.g. the generation of an object, checksum of a set of configuration values, or even a base64 encoded string representing the values as a whole).

This would cover for the alternative approach I documented in fluxcd/notification-controller#518 (comment), while allowing the source-controller to make use of this as well which hasn't a "checksum" concept but rather a reflection of observed values in full.

[matheuscscp]

@hiddeco nice! That's indeed much better. Would the revision be included in this token, or kept as a separate thing as it is today?

[hiddeco]

That's up to the emitting controller to decide, the notification-controller should just consume it as part of the key that handles rate limiting.

[matheuscscp]

That's up to the emitting controller to decide, the notification-controller should just consume it as part of the key that handles rate limiting.

Yep my question is specifically about what to do on the notification-controller side. Right now it includes the revision key from the event metadata in the rate limiting key. My question is: are we gonna replace the use of the revision key there, or just add the new one?

[hiddeco]

We would use both, as they represent different things (source being used versus declarative configuration).

[matheuscscp]

@hiddeco I updated the PR 👌

[hiddeco]

@stefanprodan @darkowlzz please take a look.

[darkowlzz]

LGTM!

Please rebase and also maybe update the PR description to not accidentally close fluxcd/helm-controller#678 as I think that requires changes in helm-controller like in fluxcd/helm-controller#681 .

[matheuscscp]

LGTM!

Please rebase and also maybe update the PR description to not accidentally close fluxcd/helm-controller#678 as I think that requires changes in helm-controller like in fluxcd/helm-controller#681 .

@darkowlzz I updated the PR description, please let me know if it works

[stefanprodan]

LGTM