Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgit2: add remaining checkout strategy tests #458

Merged
merged 2 commits into from
Oct 22, 2021
Merged

libgit2: add remaining checkout strategy tests #458

merged 2 commits into from
Oct 22, 2021

Commits on Oct 22, 2021

  1. libgit2: add remaining checkout strategy tests 

    This commit is a follow up on 4dc3185
and adds tests for the remaining checkout strategies, while
consolidating some of the logic.

The consolidated logic ensures that (SemVer) tag and commit checkouts
happen using the same "checkout detached HEAD" logic.
The branch checkout is left unmodified, and simply checks out at the
current HEAD of the given branch.

Signed-off-by: Hidde Beydals <hello@hidde.co>
    @hiddeco
    hiddeco committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    d9473d0 View commit details
    Browse the repository at this point in the history

  2. libgit2: Free most objects 

    This commit ensures most of the `git2go` objects `Free` themselves from
the underlying C object.

Ensuring all objects are freed is not possible yet, due to the way
commits are wired in to facilitate verification later on. In a later
follow up, we should change this and e.g. validate as part of the
checkout process, and move the implementation specific authentication
configuration from `git` into `libgit2`.

Signed-off-by: Hidde Beydals <hello@hidde.co>
    @hiddeco
    hiddeco committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    56201f3 View commit details
    Browse the repository at this point in the history