Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: fix reference json serialization #50

Merged
merged 2 commits into from
Apr 30, 2020
Merged

git: fix reference json serialization #50

merged 2 commits into from
Apr 30, 2020

Conversation

stefanprodan
Copy link
Member

Add omitempty to GitRepositoryRef fields.

@stefanprodan stefanprodan added the bug Something isn't working label Apr 29, 2020
hiddeco
hiddeco approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec needs to be corrected as well https://github.com/fluxcd/source-controller/blob/f2bff9053d1f3e459ffc9760201f8ed1487dc95e/docs/spec/v1alpha1/gitrepositories.md#specification

@stefanprodan
git: fix reference json serialization
c9db552 
- add omitempty to GitRepositoryRef fields
@stefanprodan stefanprodan merged commit 9c9b321 into master Apr 30, 2020
@stefanprodan stefanprodan deleted the ref-serialization branch April 30, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco