Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to allow configuration of SSH kex algos #655

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented Apr 5, 2022

Adds a runtime flag to specify which key exchange algorithms to use for ssh.

Ref: fluxcd/flux2#2610

Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be tested in a way?

main.go Outdated Show resolved Hide resolved
@aryan9600 aryan9600 force-pushed the preferred-kex branch 3 times, most recently from 28039dc to e7cf79c Compare April 5, 2022 11:43
main.go Outdated
@@ -120,6 +122,8 @@ func main() {
"The TTL of an index in the cache. Valid time units are ns, us (or µs), ms, s, m, h.")
flag.StringVar(&helmCachePurgeInterval, "helm-cache-purge-interval", "1m",
"The interval at which the cache is purged. Valid time units are ns, us (or µs), ms, s, m, h.")
flag.StringSliceVar(&kexAlgos, "ssh-kex-algos", []string{},
"The list of kex algorithms to use for ssh arranged from most preferred to least.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"The list of kex algorithms to use for ssh arranged from most preferred to least.")
"The list of key exchange algorithms to use for ssh connections, arranged from most preferred to the least.")

@pjbgf pjbgf added the area/git Git related issues and pull requests label Apr 5, 2022
@aryan9600 aryan9600 requested a review from pjbgf April 6, 2022 15:12
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @aryan9600!

LGTM

@hiddeco hiddeco added the enhancement New feature or request label Apr 7, 2022
Adds a flag `ssh-kex-algos` which configures the gogit and libgit2
managed clients to use the specified list of kex algos for ssh. If not
used the default list in `golang/x/crypto/ssh` is used.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@hiddeco hiddeco changed the title Add flag to customize kex algos Add flag to allow configuration of SSH kex algos Apr 7, 2022
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aryan9600 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants