docs(webhook-receivers.md): validation #621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lloydchang we do validate the payload for GitHub, see https://github.com/fluxcd/notification-controller/blob/main/internal/server/receiver_handlers.go#L135 |
fix fluxcd/notification-controller#256 references: https://fluxcd.io/docs/components/notification/receiver/ https://github.com/fluxcd/notification-controller/blob/main/internal/server/receiver_handlers.go#L123 https://github.com/fluxcd/notification-controller/blob/main/internal/server/receiver_handlers.go#L135 https://github.com/google/go-github/blob/v39.2.0/github/messages.go#L145:L254 https://github.com/google/go-github/blob/v39.2.0/github/messages.go#L109:L113 Signed-off-by: lloydchang <lloydchang@gmail.com>
lloydchang
changed the title
|
Please review amendment. @stefanprodan @aliusmiles Thank you. |
|
Thanks again for the work you put into this PR. It looks like it does not apply in its current state to our docs any more. I'm closing it for now. If you wish to reopen it again, please rebase on our current docs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix fluxcd/notification-controller#256
references:
https://fluxcd.io/docs/components/notification/receiver/
https://github.com/fluxcd/notification-controller/blob/main/internal/server/receiver_handlers.go#L123
https://github.com/fluxcd/notification-controller/blob/main/internal/server/receiver_handlers.go#L135
https://github.com/google/go-github/blob/v39.2.0/github/messages.go#L145:L254
https://github.com/google/go-github/blob/v39.2.0/github/messages.go#L109:L113