Guard more system headers by FMT_MODULE

fmtlib · Jun 9, 2024 · d0a29c9 · d0a29c9
1 parent 2bf811b
commit d0a29c9
Show file tree

Hide file tree

Showing 13 changed files with 33 additions and 26 deletions.
diff --git a/include/fmt/args.h b/include/fmt/args.h
@@ -8,7 +8,7 @@
 #ifndef FMT_ARGS_H_
 #define FMT_ARGS_H_
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <functional>  // std::reference_wrapper
 #  include <memory>      // std::unique_ptr
 #  include <vector>

diff --git a/include/fmt/base.h b/include/fmt/base.h
@@ -15,11 +15,11 @@
 #  include <string.h>  // strlen
 #endif
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 // <cstddef> is also included transitively from <type_traits>.
 #  include <cstddef>      // std::byte
 #  include <type_traits>  // std::enable_if
-#else
+#elif !defined(FMT_MODULE)
 import std;
 #endif
 

diff --git a/include/fmt/chrono.h b/include/fmt/chrono.h
@@ -8,7 +8,7 @@
 #ifndef FMT_CHRONO_H_
 #define FMT_CHRONO_H_
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <algorithm>
 #  include <chrono>
 #  include <cmath>    // std::isfinite

diff --git a/include/fmt/compile.h b/include/fmt/compile.h
@@ -8,7 +8,7 @@
 #ifndef FMT_COMPILE_H_
 #define FMT_COMPILE_H_
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <iterator>  // std::back_inserter
 #endif
 

diff --git a/include/fmt/format-inl.h b/include/fmt/format-inl.h
@@ -8,16 +8,19 @@
 #ifndef FMT_FORMAT_INL_H_
 #define FMT_FORMAT_INL_H_
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <algorithm>
 #  include <cmath>
 #  include <exception>
 #endif
-#include <cerrno>  // errno
-#include <climits>
 
-#if !defined(FMT_STATIC_THOUSANDS_SEPARATOR) && !defined(FMT_IMPORT_STD)
-#  include <locale>
+#ifndef FMT_MODULE
+#  include <cerrno>  // errno
+#  include <climits>
+
+#  if !defined(FMT_STATIC_THOUSANDS_SEPARATOR) && !defined(FMT_IMPORT_STD)
+#    include <locale>
+#  endif
 #endif
 
 #if defined(_WIN32) && !defined(FMT_USE_WRITE_CONSOLE)

diff --git a/include/fmt/format.h b/include/fmt/format.h
@@ -38,7 +38,7 @@
 #  define FMT_REMOVE_TRANSITIVE_INCLUDES
 #endif
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <cmath>             // std::signbit
 #  include <cstdint>           // uint32_t
 #  include <cstring>           // std::memcpy
@@ -57,14 +57,14 @@
 
 // Checking FMT_CPLUSPLUS for warning suppression in MSVC.
 #if FMT_HAS_INCLUDE(<bit>) && FMT_CPLUSPLUS > 201703L && \
-    !defined(FMT_IMPORT_STD)
+    !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <bit>  // std::bit_cast
 #endif
 
 // libc++ supports string_view in pre-c++17.
 #if FMT_HAS_INCLUDE(<string_view>) && \
     (FMT_CPLUSPLUS >= 201703L || defined(_LIBCPP_VERSION))
-#  ifndef FMT_IMPORT_STD
+#  if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #    include <string_view>
 #  endif
 #  define FMT_USE_STRING_VIEW

diff --git a/include/fmt/os.h b/include/fmt/os.h
@@ -8,17 +8,19 @@
 #ifndef FMT_OS_H_
 #define FMT_OS_H_
 
-#include <cerrno>
-#ifndef FMT_IMPORT_STD
-#  include <cstddef>
-#  include <cstdio>
-#  include <system_error>  // std::system_error
+#ifndef FMT_MODULE
+#  include <cerrno>
+#  ifndef FMT_IMPORT_STD
+#    include <cstddef>
+#    include <cstdio>
+#    include <system_error>  // std::system_error
+#  endif
 #endif
 
 #include "format.h"
 
 #if defined __APPLE__ || defined(__FreeBSD__)
-#  if FMT_HAS_INCLUDE(<xlocale.h>)
+#  if FMT_HAS_INCLUDE(<xlocale.h>) && !defined(FMT_MODULE)
 #    include <xlocale.h>  // for LC_NUMERIC_MASK on OS X
 #  endif
 #endif

diff --git a/include/fmt/ostream.h b/include/fmt/ostream.h
@@ -8,7 +8,7 @@
 #ifndef FMT_OSTREAM_H_
 #define FMT_OSTREAM_H_
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <fstream>  // std::filebuf
 #endif
 

diff --git a/include/fmt/printf.h b/include/fmt/printf.h
@@ -8,7 +8,7 @@
 #ifndef FMT_PRINTF_H_
 #define FMT_PRINTF_H_
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <algorithm>  // std::max
 #  include <limits>     // std::numeric_limits
 #endif

diff --git a/include/fmt/ranges.h b/include/fmt/ranges.h
@@ -8,7 +8,7 @@
 #ifndef FMT_RANGES_H_
 #define FMT_RANGES_H_
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <initializer_list>
 #  include <iterator>
 #  include <tuple>

diff --git a/include/fmt/std.h b/include/fmt/std.h
@@ -8,7 +8,7 @@
 #ifndef FMT_STD_H_
 #define FMT_STD_H_
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <atomic>
 #  include <bitset>
 #  include <complex>
@@ -29,7 +29,7 @@
 #  include <version>
 #endif
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 // Checking FMT_CPLUSPLUS for warning suppression in MSVC.
 #  if FMT_CPLUSPLUS >= 201703L
 #    if FMT_HAS_INCLUDE(<filesystem>)

diff --git a/include/fmt/xchar.h b/include/fmt/xchar.h
@@ -8,15 +8,16 @@
 #ifndef FMT_XCHAR_H_
 #define FMT_XCHAR_H_
 
-#ifndef FMT_IMPORT_STD
+#if !defined(FMT_IMPORT_STD) && !defined(FMT_MODULE)
 #  include <cwchar>
 #endif
 
 #include "color.h"
 #include "format.h"
 #include "ranges.h"
 
-#if !defined(FMT_STATIC_THOUSANDS_SEPARATOR) && !defined(FMT_IMPORT_STD)
+#if !defined(FMT_STATIC_THOUSANDS_SEPARATOR) && !defined(FMT_IMPORT_STD) && \
+    !defined(FMT_MODULE)
 #  include <locale>
 #endif
 

diff --git a/src/fmt.cc b/src/fmt.cc
@@ -4,6 +4,7 @@ module;
 // to prevent attachment to this module.
 #ifndef FMT_IMPORT_STD
 #  include <algorithm>
+#  include <bitset>
 #  include <chrono>
 #  include <cmath>
 #  include <complex>