Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wchar_t to char conversion warnings #3764

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Dec 19, 2023

Warnings is introduced in PR #3750

Sample:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\xutility(135,50): warning C4244: 'initializing': conversion from 'const _Elem' to '_Ty', possible loss of data [D:\a\fmt\build\test\printf-test.vcxproj]
          with
          [
              _Elem=wchar_t
          ]
          and
          [
              _Ty=char
          ]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\xutility(134): message : see reference to function template instantiation '_Ty *std::construct_at<_Ty,const _Elem&,void>(_Ty *const ,const _Elem &) noexcept(<expr>)' being compiled [D:\a\fmt\build\test\printf-test.vcxproj]
          with
          [
              _Ty=char,
              _Elem=wchar_t
  enforce-checks-test.cc
          ]

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@vitaut vitaut merged commit 9cd2b87 into fmtlib:master Dec 20, 2023
41 checks passed
@vitaut
Copy link
Contributor

vitaut commented Dec 20, 2023

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants