Better support for newer CMake's #803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged in 0eb01b8, thanks! |
|
Unfortunately I had to revert this change because it was causing problem in MSVC (#809). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the first half of #802 , and is what was recommended in #719: basically, if CMake version is less than 3.12, use the latest features. If cmake is equal or more to 3.12, just take the features from 3.11. (For each new CMake version, once it comes out and is tested, the one number that needs changing is the one in
cmake_minimum_required, since this syntax is supported in 3.12+).I've also moved the CMake version printout so that it does not print if this is not the main project (cleaner add as subdirectory).