fix: 'format_to_n' compiles 'std::back_inserter' arguments #913
Conversation
| truncating_iterator& operator++(int) { return *this; } | ||
|
|
||
| truncating_iterator& operator*() { return *this; } | ||
| }; |
There was a problem hiding this comment.
Is it possible to move common code between the two specializations into a superclass to reduce copy-paste?
DanielaE
force-pushed
the
fix/format_to_n-with-back_inserter
branch
from
58ab925
to
9dee8ab
Compare
|
Done ... |
include/fmt/format.h
Outdated
| typedef typename OutputIt::container_type::value_type value_type; | ||
| typedef void difference_type; | ||
| typedef void pointer; | ||
| typedef void reference; |
There was a problem hiding this comment.
Why are these void and are they different from their counterparts in iterator_traits?
There was a problem hiding this comment.
void actually is their type in iterator_traits. We are talking about a back_insert_operator here. I've basically just redefined the value_type from void to the value_typeof the underlying container.
There was a problem hiding this comment.
Then they can be moved to truncating_iterator_base I think.
There was a problem hiding this comment.
I agree, even if it loses information about the underlying iterator type. Anyway, I've refactored these three void typedefs into the common base class, the rest must stay as is: these are the essential differences between "regular output iterators" and "back insert interators".
std::back_insert_iterators model the OutputIterator concept but differ considerably in their traits and behavior. In particular the former made compilation to fail when format_to_n is given a back_inserter as first argument. The emulation of an OutputIterator is not perfect due to the behavioural differences of back_insert_iterators (e.g. assignment always implies increment) but good enough to be used within fmt's machinery.
DanielaE
force-pushed
the
fix/format_to_n-with-back_inserter
branch
from
9dee8ab
to
fc06d73
Compare
|
Merged, thanks! |
std::back_insert_iterators model the OutputIterator concept but differ considerably in their traits and behavior. In particular the former made compilation to fail when format_to_n is given a back_inserter as first argument. The emulation of an OutputIterator is not perfect due to the behavioural differences of back_insert_iterators (e.g. assignment always implies increment) but good enough to be used within fmt's machinery.