Fix conversion warnings #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x8000-0000
force-pushed
the
fix-more-warnings-4
branch
from
62e4771
to
bd1073d
Compare
0x8000-0000
force-pushed
the
fix-more-warnings-4
branch
2 times, most recently
from
6d904c4
to
b1c727e
Compare
0x8000-0000
commented
Dec 20, 2018
include/fmt/format.h
Outdated
| @@ -1460,7 +1460,7 @@ FMT_CONSTEXPR unsigned parse_nonnegative_int( | |||
| } | |||
| unsigned value = 0; | |||
| // Convert to unsigned to prevent a warning. | |||
| unsigned max_int = (std::numeric_limits<int>::max)(); | |||
| unsigned max_int = internal::to_unsigned(std::numeric_limits<int>::max()); | |||
There was a problem hiding this comment.
This fails to build on Windows. Somehow I get a feeling we're bitten by some max() macro coming from system headers or from the infamous <windows.h>
Ugh... so that's why it looked like that...
0x8000-0000
force-pushed
the
fix-more-warnings-4
branch
from
b1c727e
to
bfe82d8
Compare
|
Merged, thanks! |
|
@0x8000-0000, could you please review the updated CONTIBUTING document, particularly the part about licensing, and let me know if you agree with it being applied both to your contributions to {fmt}? The library is likely to be relicensed (#1073) so I'm collecting approval from all earlier contributors. Thanks! |
|
Victor,
I do agree with re-licensing my contributions under any license you find
best for the project. Thank you for your efforts so far, and for future
efforts in integrating this into C++20.
Thank you,
florin
…On 4/19/19 6:36 PM, Victor Zverovich wrote:
@0x8000-0000 <https://github.com/0x8000-0000>, could you please review
the updated CONTIBUTING
<https://github.com/fmtlib/fmt/blob/ebec00138bd10e949ff34955bcb096387cd32acc/CONTRIBUTING.md>
document, particularly the part about licensing, and let me know if
you agree with it being applied both to your contributions to {fmt}?
The library is likely to be relicensed (#1073
<#1073>) so I'm collecting
approval from all earlier contributors. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#989 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6QQNWVUAOR2EWOC5K7XJDPRJCQRANCNFSM4GLM6SAA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #983. Rebased onto current master and resolved all review comments.