Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure Boot & Virtual TPM #305

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Secure Boot & Virtual TPM #305

merged 2 commits into from
Jul 29, 2024

Conversation

nofaralfasi
Copy link
Collaborator

Add support for Secure Boot & Virtual TPM.

@nofaralfasi nofaralfasi mentioned this pull request Jul 18, 2024
Closed
chris1984
chris1984 reviewed Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, when you get the Foreman one made and it's ready to go, i'll test and ack based on testing.

@nofaralfasi nofaralfasi mentioned this pull request Jul 21, 2024
Closed
@chris1984
Copy link
Collaborator

Looks fine just 1 question, starting to test

@nofaralfasi nofaralfasi marked this pull request as draft July 24, 2024 20:15
@nofaralfasi nofaralfasi changed the title Secure Boot & Virtual TPM [WIP] Secure Boot & Virtual TPM Jul 24, 2024
@nofaralfasi nofaralfasi marked this pull request as ready for review July 25, 2024 13:45
@nofaralfasi nofaralfasi changed the title [WIP] Secure Boot & Virtual TPM Secure Boot & Virtual TPM Jul 25, 2024
@nofaralfasi nofaralfasi mentioned this pull request Jul 25, 2024
Open
chris1984
chris1984 reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@chris1984 chris1984 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, we are getting a rubocop error:
Error: Metrics/ClassLength: Class has too many lines. [290/284]

Feel free to disable the cop for that method and repush and I think we can merge this.

@chris1984 chris1984 merged commit 4de65fc into fog:master Jul 29, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nofaralfasi @chris1984 @stejskalleos