Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check: Combined length of family and style name must not exceed 20 characters #1488

Closed
davelab6 opened this issue Aug 4, 2017 · 3 comments
Closed
Assignees

Comments

@davelab6
Copy link
Contributor

davelab6 commented Aug 4, 2017

https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances says

Keep your style name short to avoid problems in Windows. How short? Well, you are on the safe side if the combined length of family and style name does not exceed 20 characters. If the name is too long, Windows may think the font is invalid.

screen shot 2017-08-04 at 11 41 33

@davelab6 davelab6 added this to the 0.5.0 Code Is Well Organized milestone Aug 4, 2017
@anthrotype
Copy link
Member

somebody with access to Windows should make some tests and confirm that this is the case.

@anthrotype
Copy link
Member

cc @moyogo

@davelab6 davelab6 modified the milestones: 0.5.0 Code Is Well Organized, 0.3.2 - Further improvements on reliability of checks and fixers Aug 22, 2017
@felipesanches felipesanches self-assigned this Aug 25, 2017
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Sep 21, 2017
This is also the first test using the new markup for rationale, affected applications/OS/browsers, etc...
And includes a proper code-test as well. Future new test requests/implementations should try to do the same.
(issue fonttools#1488)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Sep 21, 2017
This is also the first test using the new markup for rationale, affected applications/OS/browsers, etc...
And includes a proper code-test as well. Future new test requests/implementations should try to do the same.
(issue fonttools#1488)
@jenskutilek
Copy link
Contributor

I don't think this is true. Even the examples in the name table spec show names where the length of ids 1 + 2 exceeds 20 characters.

From reading this discussion I think there is confusion with the ID1 and ID2 limits, and the real issue is that the length of ID4 must be < 32 characters, while ID4 = ID1 + " " + ID2. That's also what I remember from the FontFont production guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants