CLI to take days as a unit of time (hashicorp#20477)

* CLI to take days as a unit of time * CL
fopina · May 4, 2023 · fb9324c · fb9324c
1 parent b81a94b
commit fb9324c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/changelog/20477.txt b/changelog/20477.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+cli: CLI should take days as a unit of time for ttl like flags
+```
diff --git a/command/base_flags.go b/command/base_flags.go
@@ -594,7 +594,7 @@ type DurationVar struct {
 func (f *FlagSet) DurationVar(i *DurationVar) {
 	initial := i.Default
 	if v, exist := os.LookupEnv(i.EnvVar); exist {
-		if d, err := time.ParseDuration(appendDurationSuffix(v)); err == nil {
+		if d, err := parseutil.ParseDurationSecond(v); err == nil {
 			initial = d
 		}
 	}
@@ -634,7 +634,7 @@ func (d *durationValue) Set(s string) error {
 		s = "-1"
 	}
 
-	v, err := time.ParseDuration(appendDurationSuffix(s))
+	v, err := parseutil.ParseDurationSecond(s)
 	if err != nil {
 		return err
 	}

diff --git a/command/token_create_test.go b/command/token_create_test.go
@@ -71,6 +71,12 @@ func TestTokenCreateCommand_Run(t *testing.T) {
 			"not present in secret",
 			1,
 		},
+		{
+			"ttl",
+			[]string{"-ttl", "1d", "-explicit-max-ttl", "2d"},
+			"token",
+			0,
+		},
 	}
 
 	t.Run("validations", func(t *testing.T) {