This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Upgraded ledger transactions to stargate format #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwunyeung
suggested changes
Aug 5, 2021
imports/ui/ledger/ledger.js
Outdated
| // TODO: discuss TIMEOUT value | ||
| const INTERACTION_TIMEOUT = 10000 | ||
| const REQUIRED_COSMOS_APP_VERSION = Meteor.settings.public.ledger.ledgerAppVersion || "2.16.0"; | ||
| const DEFAULT_DENOM = Meteor.settings.public.bondDenom || 'uatom'; | ||
| export const DEFAULT_GAS_PRICE = parseFloat(Meteor.settings.public.ledger.gasPrice) || 0.025; | ||
| export const DEFAULT_MEMO = 'Sent via Big Dipper' | ||
| const API = Meteor.settings.public.remote.api | ||
| const RPC = Meteor.settings.public.remote.rpc |
There was a problem hiding this comment.
@MonikaCat please add this change to default settings as well. Also should the backend read from the public values instead of the private values in the settings.json?
There was a problem hiding this comment.
Ok! I moved remote part under public section and updated the default_settings.json file. Also I have set RPC and API as global constants in main.js
|
I got this when I would like to sign a
|
|
Another error on
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #529
Checklist
meteor npm run lintCHANGELOG.mdfile.Files changedin the Github PR explorer.