Cristi/schedule e2e tests #5161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daphne-sfdc
approved these changes
Oct 17, 2023
|
will these be run as part of nightly runs? if yes, do we get any notifications for these runs on email or slack? |
|
@diyer Yes, the tests would run nightly. Regarding the notifications, right now we don't get any. Gordon was going to create a WI to address that and some other e2e details to consider. |
|
@CristiCanizales qq: why do you use [skip-validate-pr] on this PR ? |
|
@diyer We use that when the work/change was simple enough to not require a WI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Functionality Before
Functionality After
These runs were triggered on my fork with a workflow like the one I fixed in this PR:
They're failing because I don't have the right setup on my fork (secrets and all that) but they're being run automatically as scheduled
[skip-validate-pr]