chore: Improve handling of unchanged certificates #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new release based on commit 7a5998dRelease tag: v2.6.1-f3-7a599-mike-certificate-changed-check |
Created new release based on commit 23f8f96Release tag: v2.6.1-f3-23f8f-mike-certificate-changed-check |
Created new release based on commit 2382457Release tag: v2.6.1-f3-23824-mike-certificate-changed-check |
Created new release based on commit 4c61c8dRelease tag: v2.6.1-f3-4c61c-mike-certificate-changed-check |
Created new release based on commit a82410aRelease tag: v2.6.1-f3-a8241-mike-certificate-changed-check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid endless loop for unchanged cert. If the certificate details have not changed, skip the ready check.
Additionally, make the
CertificateExpiryandRenewBeforefields required, not optional, and remove default values.