Change duration measurement from days to hours #1046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value for the lifetime of a legit ticket is 10h, so a longer one could be suspicious. It is not possible to set a lifetime shorter than 1 day due to the fact that the data type of the duration parameter is int and it is measured in days. The measurement is changed from days to hours because the value considered opsec is 10h. The default value for the duration parameter is still 10 years for anyone who doesn't care about opsec. The data type is now float in case someone wants to set a decimal value.
|
these changes were merged in the context of #1411. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for the lifetime of a legit ticket is 10h, so a longer one could be suspicious.
It is not possible to set a lifetime shorter than 1 day due to the fact that the data type of the duration parameter is int and it is measured in days.
The measurement is changed from days to hours because the value considered opsec is 10h. The default value for the duration parameter is still 10 years for anyone who doesn't care about opsec. Now the data type is float in case someone wants to set a decimal value.