Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ABC from collections.abc for Python 3.10 compatibility. #1281

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Import ABC from collections.abc for Python 3.10 compatibility. #1281

merged 1 commit into from
Jul 18, 2022

Conversation

tirkarthi
Copy link
Contributor

Ref : python/cpython#23754

ABC aliases were removed from collections in favor of collections.abc

Copy link

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Between Python 3.3 and 3.9, Mapping was in both collections and collections.abc

But in Python 3.10 it was removed from collections and is only available in collections.abc.

Because only 3.6 and up is supported here, this is change is safe to make for 3.6-3.9, and is needed for 3.10 and up.

@0xdeaddood 0xdeaddood added the in review This issue or pull request is being analyzed label Apr 18, 2022
@0xdeaddood 0xdeaddood merged commit 424c0bc into fortra:master Jul 18, 2022
@0xdeaddood 0xdeaddood removed the in review This issue or pull request is being analyzed label Jul 18, 2022
@0xdeaddood
Copy link
Collaborator

Thanks @tirkarthi for the PR and @hugovk for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants