Extend spec with publishing time data #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
commented
Dec 13, 2022
achim-k
commented
Dec 13, 2022
achim-k
commented
Dec 13, 2022
jtbandes
approved these changes
Dec 13, 2022
achim-k
force-pushed
the
achim/spec_time_data
branch
2 times, most recently
from
3609b40
to
5c26bca
Compare
achim-k
force-pushed
the
achim/spec_time_data
branch
from
5c26bca
to
b85ab2e
Compare
|
@jtbandes @jhurliman I have now also added the necessary adaptation to |
jtbandes
reviewed
Dec 13, 2022
jhurliman
approved these changes
Dec 14, 2022
jhurliman
pushed a commit
to foxglove/ros-foxglove-bridge
that referenced
this pull request
Dec 14, 2022
**Public-Facing Changes** - Publish binary time data when `use_sim_time` is `true` **Description** Depends on foxglove/ws-protocol#299 - When the `use_sim_time` parameter is set - The server advertises the `time` capability - It subscribes to the `/clock` topic and broadcasts binary time messages - I have removed the code that detects presence of the `/clock` topic, since now it has to be known at startup whether `use_sim_time` is true or false - Includes #115 (will rebase after it got merged)
pezy
pushed a commit
to pezy/ws-protocol
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
@foxglove/ws-protocolaccordinglySupersedes #298