Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for 2D cellvoyager conversion & drop macos tests for Python 3.9 & Python 3.10 #726

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

jluethi
Copy link
Collaborator

@jluethi jluethi commented Apr 25, 2024

Closes #684

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_tasks_core/tasks
  cellvoyager_to_ome_zarr_compute.py
Project Total  

This report was generated by python-coverage-comment-action

@jluethi
Copy link
Collaborator Author

jluethi commented Apr 25, 2024

It appears that Python 3.9 & macos 14 (which is slowly rolling out on CI) is making issues on Github CI due to issues described here: actions/setup-python#696 (comment)

I will exclude macos Python 3.9 for us, as it's not essential to test all Python versions on all os for our package. Given what appears to be available on those new runners, I'm also dropping macos Python 3.10: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-arm64-Readme.md#cached-tools
(otherwise tests will probably fail once we get macos 14 runners for 3.10)

We could manually install Python e.g. via brew on mac runners, but I don't think that's worth the complexity & additional CI time for us. As long as we have 1 macos version being tested.

=> Conclusion is that we'll test broadly on Linux (3.9 - 3.11) & just run 3.11 for macos.

@jluethi jluethi changed the title Add test for 2D cellvoyager conversion Add test for 2D cellvoyager conversion & drop macos tests for Python 3.9 & Python 3.10 Apr 25, 2024
@jluethi
Copy link
Collaborator Author

jluethi commented Apr 25, 2024

@tcompa I'm merging this now to get the CI working again. Feel free to open new issues/PRs to improve this later :)

@jluethi jluethi merged commit 58ca8a9 into main Apr 25, 2024
16 checks passed
@jluethi jluethi deleted the 684_2D_conversion_tests branch April 25, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for converting 2D data
1 participant