Bump deps; set Java version centrally; define minimum Maven version; … #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix tools.jar dep
nielsm5
approved these changes
Oct 16, 2023
nielsm5
reviewed
Oct 16, 2023
frank-doc-doclet/pom.xml
Outdated
Comment on lines
259
to
260
| <scope>system</scope> | ||
| <systemPath>${java.home}/../lib/tools.jar</systemPath> |
There was a problem hiding this comment.
Ik weet niet of dit op de CI goed gaat.. de dependency staat bij ons op de nexus. Dus dit is niet nodig.
There was a problem hiding this comment.
java.home is by default gedefinieerd door de JDK. De tools.jar werkt bij mij niet by default, met Java 8. Dus dit lijkt me een meer standaard oplossing. Maar goed, het is even een tussentijdse fix, want in mijn nieuwe branch gaat die hele dep er uit.
nielsm5
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fix tools.jar dep
Some Java 11 preps.