Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an 'unsafe' field, which documents if the attribute is considered unsafe and should not be used in a production environment. #202

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Add an 'unsafe' field, which documents if the attribute is considered unsafe and should not be used in a production environment. #202

merged 6 commits into from
Sep 5, 2024

Conversation

thomaspj10
Copy link
Contributor

@thomaspj10 thomaspj10 commented Aug 30, 2024 •
edited
Loading

Closes #197

Continuation of frankframework/frankframework#2727

  • Adds a field unsafe to the JSON, which can be used by the frontend to add a visual warning.
  • A footnote is added to the documentation inside the XSD when an attribute is unsafe.

@thomaspj10 thomaspj10 marked this pull request as ready for review August 30, 2024 08:44
@nielsm5 nielsm5 merged commit 4441188 into master Sep 5, 2024
2 checks passed
@nielsm5 nielsm5 deleted the frankdoc/197-add-unsafe-label branch September 5, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evandongen evandongen evandongen approved these changes

@nielsm5 nielsm5 nielsm5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unsafe label
3 participants
@thomaspj10 @evandongen @nielsm5