Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands must return an exit status #102

Merged
merged 2 commits into from
May 24, 2020

Conversation

apfelbox
Copy link
Collaborator

Hi,

since Symfony 5 commands must return a status code, see:

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L261

So while the composer.json currently allows to install it with Symfony 5, running any command will just crash.

@apfelbox
Copy link
Collaborator Author

The second commit bumps phpspec/phpspec, as the previous version was really old.
It also uses a different branch for composer/composer, as their dev-master is now for v2, which doesn't (yet) work with this plugin.

@franzliedke franzliedke merged commit 842bfe6 into franzliedke:master May 24, 2020
@franzliedke
Copy link
Owner

Thanks a lot, I appreciate it!!! ❤️

@franzliedke
Copy link
Owner

I had to downgrade phpspec again by a bit, because the tests were failing in master. (I hadn't configured GitHub Actions properly, so the tests were not run for PRs. 🤕.)

@apfelbox
Copy link
Collaborator Author

Thank you for merging! @franzliedke

Ah, I did only run them with PHP 7.4, so they were green. 😅
Do you already have an ETA for the next tagged version? Locally I installed it via dev-master#... as 0.14.0 but would be glad to update to a release. 😄

@apfelbox apfelbox deleted the fix-commands-sf5 branch May 25, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants