-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Composer 2 #104
Conversation
3f303a4
to
862ff1d
Compare
The plugin has issues with canonical repos it seems. It's a chicken/egg situation. When the plugin adds the path repo to Composer 2, it treats it as a canonical repo, which means that usecases where a package with required version cannot be found in path (e.g. different versions - If we set the repo to be non-canonical, then it seems that the repo is simply ignored, since the valid version (be it e.g. |
@franzliedke is there any way that the community can help you out in getting this PR merged and released? :-) |
Hey @franzliedke, could you spare a few min and please merge this PR? That would be appreciated :) |
I've noticed this project is now marked abandoned in my setup. I have this as a dependency. Perhaps you can allow someone to take it over or someone who is willing can fork it if there is no response. |
Hello folks. I'm happy about the interest in keeping this maintained. Is anybody interested in pairing on this, e.g. on Friday? @roni-estein Can you share where this is marked as abandoned? Or are you referring to the Composer CLI warning? |
Yeah! 🎉 @franzliedke I would be willing help out with maintenance and development, if you need any help! |
@franzliedke please merge this PR, it's the only thing keeping me (and probably others) from updating Composer to 2.0 |
Yes, it was the CLI warning, sorry I missed this earlier. I've started removing it from my projects I misunderstood the warning. I didn't realize composer would give that alert without the actual project being abandoned. |
This is an amazing package, we want this! :) |
@emodric Thanks very much - I will release a new version with this shortly. (Currently also doing some other cleanup, with the help of @apfelbox.) Regarding the problem with canonical repositories you mentioned: it seems to boil down to a combination of a repository that's both present in a local path and on Packagist, and a mismatch between your version constraint and the local version, right? Please open a new issue with minimal reproduction steps! 🙏 I can't stop thinking that my experimental approach from this release is the way to go. @Vikingmaster Feel free to support me via GitHub Sponsors or https://paypal.me/franzliedke. 😉 |
Big thank you. |
Relased in version 0.15.0. Please update and let me know if you encounter any problems. |
Thanks @franzliedke for merging ! As for my issue with canonical repos, yes, it happens when there's a mismatch in versions specified in Additionaly, even if the versions match, it seems that path repos are considered as Both of these cases worked on Composer 1. |
@franzliedke Here are the two reproducers for two issues noted above: |
No description provided.