Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more recent PHPUnit and PHPSpec versions #76

Merged
merged 2 commits into from
Sep 15, 2017
Merged

Use more recent PHPUnit and PHPSpec versions #76

merged 2 commits into from
Sep 15, 2017

Conversation

Arcesilas
Copy link
Contributor

PHPUnit: use 6.3 instead of 4.0
PHPSpec: use 4.0 instead of 2.0

@Arcesilas
Copy link
Contributor Author

By the way, it would be nice to use the latest version (without hard coding version number) or let users specify version of their choice. What do you think ?

@Arcesilas
Copy link
Contributor Author

PHPSpec dropped HHVM support (phpspec/phpspec#1139). If HHVM is really required to be supported by Studio, you might consider dropping PHPSpec dependency.

@franzliedke
Copy link
Owner

Did PHPSpec drop support already, or are they considering it? (The link looks more like the latter.)

@franzliedke franzliedke merged commit da3cc1c into franzliedke:master Sep 15, 2017
@franzliedke
Copy link
Owner

Anyway, thanks for the merge!

We could implement HHVM support as an additional part (with an additional question) that would then add this line to the travis.yml file...

@franzliedke
Copy link
Owner

Released in v0.12.0. Thanks again!

@Arcesilas
Copy link
Contributor Author

They dropped hhvm support on Dec 29, 2016: phpspec/phpspec@ddccee6#diff-354f30a63fb0907d4ad57269548329e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants