Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an --options argument to provide options to 'git clone' and 'git submodule add' #93

Merged
merged 1 commit into from
Jun 2, 2019

Conversation

gnutix
Copy link
Contributor

@gnutix gnutix commented May 22, 2019

I wanted to run studio create --git ... and checkout a specific branch. Here's the code that allows to do it and what it looks like :

studio create packages/liip/functional-test-bundle --git git@github.com:gnutix/LiipFunctionalTestBundle.git --options="--single-branch --branch=symfony43compat"

studio create packages/liip/functional-test-bundle --submodule git@github.com:gnutix/LiipFunctionalTestBundle.git --options="-b symfony43compat"

@franzliedke
Copy link
Owner

Hey, thanks for this proposal and an even bigger thanks for implementing it already! 🙌

Just one remark: what about avoiding the extra --options argument with awkward CLI quoting and just passing all other arguments (besides --git and --submodule, obviously) through to the Git command?

@gnutix
Copy link
Contributor Author

gnutix commented May 27, 2019

I thought about it too, but I'm not sure how to implement this with Symfony Console (fetching all "extra" arguments not defined in the Command and passing them through) - I never had to do it yet. Unfortunately, I don't really have more time to put into it right now.

@franzliedke
Copy link
Owner

Oh well, good enough for now. Thanks a lot!

@franzliedke franzliedke merged commit 27e2c5c into franzliedke:master Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants