Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 5.0 #98

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Allow Symfony 5.0 #98

merged 1 commit into from
Nov 29, 2019

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Nov 25, 2019

No description provided.

@franzliedke franzliedke merged commit 013cce6 into franzliedke:master Nov 29, 2019
@franzliedke
Copy link
Owner

Thanks a lot!

@simonberger
Copy link

@emodric @franzliedke It seems not to be compatible to symfony 5 though

PHP Fatal error: Uncaught TypeError: Argument 1 passed to Symfony\Component\Process\Process::__construct() must be of the type array, string given

https://github.com/symfony/symfony/blob/5.0/UPGRADE-5.0.md#process

@emodric
Copy link
Contributor Author

emodric commented Jan 28, 2020

Doh! When I tested the package, I somehow didn't notice that I was using Symfony 4.4 instead of 5.0, so there were no issues :/

What would be the best way to fix this? Some form of version detection? The new syntax was introduced in Symfony 3.3 I believe.

franzliedke added a commit that referenced this pull request Dec 18, 2020
@franzliedke
Copy link
Owner

@emodric @simonberger That problem only occurred within studio create, right? That now works with Symfony 5 after this commit.

This has been relased in version 0.15.0.

@simonberger
Copy link

I absolutely don't remember what I did back then 😎

@emodric
Copy link
Contributor Author

emodric commented Dec 18, 2020

I don't really remember either 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants