-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expire_allocation api endpoint by fetching allocation object #1576
fix: expire_allocation api endpoint by fetching allocation object #1576
Conversation
…tr in the expire_allocation endpoint
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1576 +/- ##
===========================================
- Coverage 72.85% 72.80% -0.05%
===========================================
Files 202 202
Lines 11169 11173 +4
===========================================
- Hits 8137 8135 -2
- Misses 3032 3038 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for this?
Yes, will add. |
@krantheman I have added the test case. |
) * fix: expire_allocation api endpoint by fetching allocation object * fix: add a check to fetch allocation only if the allocation type is str in the expire_allocation endpoint * feat: add a test case test_expire_allocation for leave ledger entry doctype (cherry picked from commit 6ddfdac) # Conflicts: # hrms/hr/doctype/leave_allocation/leave_allocation.js
) * fix: expire_allocation api endpoint by fetching allocation object * fix: add a check to fetch allocation only if the allocation type is str in the expire_allocation endpoint * feat: add a test case test_expire_allocation for leave ledger entry doctype (cherry picked from commit 6ddfdac)
…ckport #1576) (#2195) * fix: expire_allocation api endpoint by fetching allocation object * fix: add a check to fetch allocation only if the allocation type is str in the expire_allocation endpoint * feat: add a test case test_expire_allocation for leave ledger entry doctype (cherry picked from commit 6ddfdac) Co-authored-by: zeel prajapati <zeelprajapati321@gmail.com>
…ckport #1576) (#2194) * fix: expire_allocation api endpoint by fetching allocation object (#1576) * fix: expire_allocation api endpoint by fetching allocation object * fix: add a check to fetch allocation only if the allocation type is str in the expire_allocation endpoint * feat: add a test case test_expire_allocation for leave ledger entry doctype (cherry picked from commit 6ddfdac) # Conflicts: # hrms/hr/doctype/leave_allocation/leave_allocation.js * chore: fix conflicts --------- Co-authored-by: zeel prajapati <zeelprajapati321@gmail.com> Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Add the code to fetch
allocation
inexpire_allocation
endpoint so that after code not break.Traceback of error which is fixed