-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Employee Attendance Tool): 'On Leave' status showing as undefined in marked attendance summary #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
changed the title
Employee Attendance Tool On Leave Status showing in undefined Change to On Leave
fix(Employee Attendance Tool): 'On Leave' status showing as undefined in marked attendance summary
May 1, 2024
@creative-paramu Thanks for the fix. Try sticking to conventional commit messages in your future commits: https://www.conventionalcommits.org/en/v1.0.0/ |
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 1, 2024
## [15.20.2](v15.20.1...v15.20.2) (2024-05-01) ### Bug Fixes * autofill skills on entering designation in Interview Round (backport [#1706](#1706)) ([#1735](#1735)) ([f3961b7](f3961b7)) * **Employee Advance:** selection of currency ([ee86b5d](ee86b5d)) * **Employee Attendance Tool:** 'On Leave' status showing as undefined in marked attendance summary (backport [#1712](#1712)) ([#1733](#1733)) ([34894c0](34894c0)) * **Leave Application:** half day date picker rendering (backport [#1643](#1643)) ([#1731](#1731)) ([9ff1f14](9ff1f14)) * merge conflicts ([29cbccd](29cbccd)) * ruff linting issues ([aa47352](aa47352)) * semgrep errors ([e77021a](e77021a))
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 1, 2024
# [14.27.0](v14.26.2...v14.27.0) (2024-05-01) ### Bug Fixes * autofill skills on entering designation in Interview Round (backport [#1706](#1706)) ([#1734](#1734)) ([fb5294a](fb5294a)) * **Employee Advance:** selection of currency ([68728db](68728db)) * **Employee Attendance Tool:** 'On Leave' status showing as undefined in marked attendance summary (backport [#1712](#1712)) ([#1732](#1732)) ([af1b2ba](af1b2ba)) * **Leave Application:** half day date picker rendering (backport [#1643](#1643)) ([#1730](#1730)) ([cba9824](cba9824)) * merge conflicts ([cccda2e](cccda2e)) * more ruff linting issues ([f268a10](f268a10)) * ruff linting issues ([7b2685d](7b2685d)) * ruff linting issues ([8141c89](8141c89)) * semgrep errors ([9773e85](9773e85)) ### Features * **Attendance Request:** add 'Include Holidays' checkbox (backport [#1040](#1040)) ([#1727](#1727)) ([12ff8c7](12ff8c7))
Ok Mam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Employee Attendance Tool Marked Attendance On Leave Status showing in undefined ,
Closes: #1711
Before:
After: