Allow object expression without overrides. #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
edgarfgp
force-pushed
the
allow-object-expression-without-overrides
branch
from
7105148
to
6520c5d
Compare
|
From what I understand, there's a difference from the original suggesion, which is: we allow any member-less expressions in object expressions, an not only for abstract classes, but regular ones as well (as you mentioned here: fsharp/fslang-suggestions#632 (comment)), I'm fine with it as long as @dsyme is, as it feels more uniformed, despite the fact it was explicitly disallowed in the past. |
dsyme
approved these changes
Aug 19, 2024
|
This looks great to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click “Files changed” → “⋯” → “View file” for the rendered RFC.