include source link enabled pdb files with Paket.Core nupkg #2313
Conversation
| @@ -3,6 +3,7 @@ | |||
| <DebugType>portable</DebugType> | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="SourceLink.Create.CommandLine" Version="2.1.0" PrivateAssets="all" /> | |||
| <PackageReference Include="SourceLink.Create.CommandLine" Version="2.1.1" PrivateAssets="all" /> | |||
| <PackageReference Include="SourceLink.Embed.PaketFiles" Version="2.1.1" PrivateAssets="all" /> | |||
There was a problem hiding this comment.
I moved the below targets into its own package, so that others could easily use it.
| @@ -10,3 +10,4 @@ projecturl http://fsprojects.github.com/Paket | |||
| iconurl https://raw.githubusercontent.com/fsprojects/Paket/master/docs/files/img/logo.png | |||
| tags | |||
| nuget, bundler, F# | |||
| include-pdbs true | |||
There was a problem hiding this comment.
Packs the pdb for net45.
| <Pack>true</Pack> | ||
| <PackagePath>lib/netstandard1.6</PackagePath> | ||
| </Content> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Packs the pdb for netstandard1.6.
|
I never liked that this doesn't work on linux and restricts releases to windows tbh :/ (Sorry I need to say that with a gentoo logo ;)) |
|
Releases are made on Windows anywao
Am 03.05.2017 8:15 nachm. schrieb "Matthias Dittrich" <
notifications@github.com>:
… I never liked that this doesn't work on linux and restricts released to
windows tbh :/ (Sorry I need to say that with a gentoo logo ;))
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2313 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNEy98ABGH8M3C_oHEpRpjDfCtdSeks5r2MQ1gaJpZM4NPMct>
.
|
|
;) |
|
@matthid I'm not sure I understand. Are you talking about the creation of portable pdb? If so, then it should work once Linux is on dotnet core. |
|
@ctaggart Yes. I talk about the nuget release. When we start adding pdbs to the nuget we are windows only when trying to actually do the release ;). I'm not saying we shouldn't do it. Just that I never liked it (and never actually used SourceLink, because I usually automate my release process on my linux/jenkins box).
Yes I hope it :) I always wanted to use this :P (and even started to implement a pdb writer, but it was way to much work :P) |
|
@matthid Have a look at SourceLink version 2. It should work on Linux as well. The only requirement is MSBuild 15. |
|
thanks! |
This is a followup to #2200, which simply includes the source linked
Paket.Core.pdbfiles in the Paket.Core nupkg. I had to restore some changes from #2200 that were dropped. Please review. cc @cloudRoutine