Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Heading 컴포넌트 추가 #31

Merged
merged 7 commits into from
Jul 17, 2023
Merged

feat: Heading 컴포넌트 추가 #31

merged 7 commits into from
Jul 17, 2023

Conversation

Leejin-Yang
Copy link
Collaborator

Issue

✨ 구현한 기능

  • Heading 컴포넌트 추가

📢 논의하고 싶은 내용

x

🎸 기타

  • FontWeightKeys 타입이 Text 컴포넌트와 중복되어 theme에서 타입 추가했습니다.

@Leejin-Yang Leejin-Yang self-assigned this Jul 15, 2023
xodms0309
xodms0309 approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@xodms0309 xodms0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔꼼하고만요~ LGTM 🐈

hae-on
hae-on approved these changes Jul 16, 2023
View reviewed changes
Copy link
Collaborator

@hae-on hae-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구우우우웃~~👍

@Leejin-Yang
Copy link
Collaborator Author

@xodms0309 @hae-on
중복 타입 제거랑 문서 작성했는데 확인해주세요 😊

@hae-on
Copy link
Collaborator

hae-on commented Jul 16, 2023

얍 확인 완료!

@Leejin-Yang Leejin-Yang merged commit b816d55 into main Jul 17, 2023
1 check passed
@Leejin-Yang Leejin-Yang deleted the feat/issue-27 branch July 17, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xodms0309 xodms0309 xodms0309 approved these changes

@hae-on hae-on hae-on approved these changes

Assignees

@Leejin-Yang Leejin-Yang

Labels
✨ Feature 🎨 UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heading 컴포넌트 추가
3 participants
@Leejin-Yang @hae-on @xodms0309