input 옮기기 & 리드미 작성 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BottomSheet 컴포넌트 파일에서 containerElement를 보면 dialog-container를 못 가져와서 에러 나는 걸로 보여요! https://storybook.js.org/docs/react/configure/story-rendering#adding-to-body |
|
아 맞네...크로마틱 환경일 때를 생각 못했어요. 이게 디자인 시스템에는 preview-body.html이 없어서 제가 스토리북일 때는 Bottom Sheet가 Body에 붙도록 했거든요.. 오짜면 좋죠...ㅠ |
|
preview-body.html를 추가하는건 어떤가요.? |
|
@Leejin-Yang |
xodms0309
approved these changes
Nov 5, 2023
| argTypes: { | ||
| rightIcon: { | ||
| control: { type: 'boolean' }, | ||
| mapping: { false: '', true: '🔎' }, |
Leejin-Yang
approved these changes
Nov 5, 2023
README.md
Outdated
Comment on lines
50
to
51
| <Badge color="#000" textColor="#fff" size="md"/> | ||
| <Badge color="#000" textColor="#fff" /> |
There was a problem hiding this comment.
Badge에 children 있지 않나요..?
| ## Link | ||
|
|
||
| 다른 URL로 연결하는 컴포넌트입니다. | ||
| `react-router-dom`과 함께 사용할 수 있습니다. | ||
| 다른 URL로 연결하는 컴포넌트입니다. `react-router-dom`과 함께 사용할 수 있습니다. |
README.md
Outdated
| | size | number | Spacing 컴포넌트의 크기입니다. | | ||
| | props | value | description | | ||
| | ---------- | --------------------------------------------- | ------------------------------ | | ||
| | direction? | vertical, horizontal<br /> (default: default) | Spacing 컴포넌트의 방향입니다. | |
There was a problem hiding this comment.
Suggested change
| | direction? | vertical, horizontal<br /> (default: default) | Spacing 컴포넌트의 방향입니다. | | |
| | direction? | vertical, horizontal<br /> (default: vertical) | Spacing 컴포넌트의 방향입니다. | |
default: vertical로 되어 있슴다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
input을 옮기고 리드미를 수정하였습니다.
📢 논의하고 싶은 내용
리드미 잘못된 부분 있으면 말해주세용
그리고 input 스토리북에 검색 아이콘이 있었는데 그냥 이모지로 대체했습니다!
Bottom Sheet가 크로마틱 UI 에러가 나네요 ㅠㅠㅠ 왜죠...?
🎸 기타
x