Carousel 추가 #82
Merged
Carousel 추가 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xodms0309
reviewed
Nov 5, 2023
src/Carousel/Carousel.stories.tsx
Outdated
Comment on lines
5
to
6
| import { RecipeItem } from '@/components/Recipe'; | ||
| import mockRecipe from '@/mocks/data/recipes.json'; |
src/types.ts
Outdated
Comment on lines
10
to
13
| export interface CarouselChildren { | ||
| id: number; | ||
| children: ReactNode; | ||
| } |
There was a problem hiding this comment.
해온 의견대로 굳이 import 안하고 해당 컴포넌트에서 정의해도 써도 될 것 같아요
src/Carousel/Carousel.stories.tsx
Outdated
Comment on lines
35
to
51
| export const RecipeRanking: Story = { | ||
| args: { | ||
| carouselList: [ | ||
| { | ||
| id: 0, | ||
| children: <RecipeItem recipe={mockRecipe.recipes[0]} />, | ||
| }, | ||
| { | ||
| id: 1, | ||
| children: <RecipeItem recipe={mockRecipe.recipes[1]} />, | ||
| }, | ||
| { | ||
| id: 2, | ||
| children: <RecipeItem recipe={mockRecipe.recipes[2]} />, | ||
| }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
어차피 여기는 공통 컴포넌트를 작성하는 곳이라 얘도 지워도 될 것 같아요! 얘는 우리 도메인 관련이니까!
src/Carousel/Carousel.stories.tsx
Outdated
| import mockRecipe from '@/mocks/data/recipes.json'; | ||
|
|
||
| const meta: Meta<typeof Carousel> = { | ||
| title: 'common/Carousel', |
There was a problem hiding this comment.
디자인 시스템에서는 title을 그냥 컴포넌트 이름으로 줬었네요!
Leejin-Yang
approved these changes
Nov 5, 2023
src/types.ts
Outdated
Comment on lines
10
to
13
| export interface CarouselChildren { | ||
| id: number; | ||
| children: ReactNode; | ||
| } |
|
type에서 import 하던거 빼고 바로 Carousel 컴포넌트에서 받도록 했습니다. 리드미도 확인해주세요! 이렇게 바꿨거든요? 혹시 맘에 안들면 말해주세욤 const carouselList = [0, 1, 2].map((index) => ({
id: index,
children: <div>{index}</div>,
})); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
�Carousel을 추가하였습니다.
📢 논의하고 싶은 내용
일단 있는그대로 붙였는데
이 부분 import 하지말고
이렇게 바로 써야할까요?
뭐가 좋은지 몰라서 여쭈어봅니다.
일단 그래서 JSDocs랑 README 다 안 적었어요.
디자인 시스템에 너무 뭐가 없어서 �Carousel 끼워넣긴 했는데
또 넣다보니 넣는게 맞나 생각도 드네욤
토스트는 넣는거 어때요?
많은 의견 주세요!
🎸 기타
x