Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The status badge for onlabel_CRAN_checks always picks up the latest run #132

Closed
j-i-l opened this issue Jul 16, 2024 · 0 comments · Fixed by #130
Closed

The status badge for onlabel_CRAN_checks always picks up the latest run #132

j-i-l opened this issue Jul 16, 2024 · 0 comments · Fixed by #130
Assignees

Comments

@j-i-l
Copy link
Collaborator

j-i-l commented Jul 16, 2024

On Label CRAN Checks
Since we use the onlabel_CRAN_checks workflow on label of pull requests we end up with a status badge on the homepage of the package that indicates the status for some pull request and not for a version we would like to display.

The check should either indicate the state when running on main or on the latest release-x.y.z branch that has a published tag.

Since the workflow runs on pull requests, it never runs on main directly.

What we could do it so simply update the URI for the badge in the README.md when we create a new release-x.y.z pull request, much like we already do when updating the NEWS.md file.
When we then publish the version by merging the pull request the badge in the README.md will points to the outcome of the latest onlabel_CRAN_checks on the branch release-x.y.z of the latest release.

@j-i-l j-i-l self-assigned this Jul 16, 2024
@j-i-l j-i-l changed the title ![On Label CRAN Checks](https://github.com/furrer-lab/abn/actions/workflows/onlabel_CRAN_checks.yml/badge.svg)](https://github.com/furrer-lab/abn/actions/workflows/onlabel_CRAN_checks.yml) always picks up the latest run The status badge for onlabel_CRAN_checks always picks up the latest run Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant