Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

127 run autoconf or autoreconf and commit configure file when creating new release branch #130

Conversation

j-i-l
Copy link
Collaborator

@j-i-l j-i-l commented Jul 16, 2024

Closes #127

Closes #132

Closes #135

@j-i-l j-i-l self-assigned this Jul 16, 2024
@j-i-l j-i-l mentioned this pull request Jul 16, 2024
@j-i-l j-i-l mentioned this pull request Jul 16, 2024
@j-i-l
Copy link
Collaborator Author

j-i-l commented Jul 16, 2024

@matteodelucchi with this pr we create the configure file from the configure.ac file when opening a pull request for a new release - #127

At the same time, the status badge for onlabel_CRAN_checks in the README.md also points to this release branch - #132

Thus when we create a new release by merging the branch we update the configure file in the main branch, as well as, the README.md also gets an updated status badge that points to the workflow that ran on the version that was released last.

- name: Update status badges in the readme file
run: |
# updated the branch parameter for all badges
sed -i -e "s/?branch=release-${{ steps.release_version.outputs.previous_version}}/?branch=release-${{ steps.release_version.outputs.version}}/g" README.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

- name: Update status badges in the readme file
run: |
# updated the branch parameter for all badges
sed -i -e "s/?branch=release-${{ steps.release_version.outputs.previous_version}}/?branch=release-${{ steps.release_version.outputs.version}}/g" README.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this as wildcard: [0-9]\+.[0-9]\.[0-9]\+

@j-i-l j-i-l merged commit 236ec8a into main Jul 18, 2024
5 checks passed
@j-i-l j-i-l deleted the 127-run-autoconf-or-autoreconf-and-commit-configure-file-when-creating-new-release-branch branch August 7, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants