-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
127 run autoconf or autoreconf and commit configure file when creating new release branch #130
Merged
j-i-l
merged 6 commits into
main
from
127-run-autoconf-or-autoreconf-and-commit-configure-file-when-creating-new-release-branch
Jul 18, 2024
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cb69375
automatically regenerate configure file
j-i-l 1e43957
avoid hardcoding branch
j-i-l c13e0ee
Revert "avoid hardcoding branch"
j-i-l 939bb1e
targeting the latest release branch for the status badge
j-i-l 3661746
automatically update status badges
j-i-l 5b55e39
capture all version strings in release-x.y.z
j-i-l File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,7 @@ jobs: | |
echo "VERSION=`echo $(echo '${{ github.ref_name }}'|grep -Eo '[0-9]+.[0-9]+.[0-9]+')`" >> $GITHUB_OUTPUT | ||
echo "PREVIOUS_VERSION=`echo $(git tag --list --sort=version:refname | grep -E '^[0-9]+.[0-9]+.[0-9]+$' | tail -n1)`" >> $GITHUB_OUTPUT | ||
echo "AUTHOR=`echo $(git log -1 --pretty=%an)`" >> $GITHUB_OUTPUT | ||
|
||
- name: Get git-chglog and update CHANGELOG | ||
run: | | ||
wget ${{ env.CHGLOG_PATH }}/${{ env.CHGLOG_RELEASE}}.tar.gz # get the binary for the chglog | ||
|
@@ -63,10 +64,12 @@ jobs: | |
uses: r-lib/actions/setup-r@v2 | ||
with: | ||
use-public-rspm: true | ||
|
||
- name: Install desc to update DESCRIPTION file | ||
run: | | ||
install.packages(c("desc")) | ||
shell: Rscript {0} | ||
|
||
- name: Update DESCRIPTION file | ||
run: | | ||
df = desc::description$new(file='DESCRIPTION') | ||
|
@@ -80,6 +83,16 @@ jobs: | |
sed -i -e '/^AC_INIT/s/[0-9]\+.[0-9]\.[0-9]\+/${{ steps.release_version.outputs.version }}/g' configure.ac | ||
shell: bash | ||
|
||
- name: Generate the configure file | ||
run: | | ||
sudo apt-get -y install autoconf | ||
autoreconf | ||
|
||
- name: Update status badges in the readme file | ||
run: | | ||
# updated the branch parameter for all badges | ||
sed -i -e "s/?branch=release-${{ steps.release_version.outputs.previous_version}}/?branch=release-${{ steps.release_version.outputs.version}}/g" README.md | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. make this as wildcard: |
||
|
||
- name: Create version release Pull Request | ||
id: release_pr | ||
# NOTE: We might want to perform this step with gh cli natively | ||
|
@@ -89,9 +102,11 @@ jobs: | |
commit-message: "Version ${{ steps.release_version.outputs.version }}" | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
add-paths: | | ||
README.md | ||
NEWS.md | ||
DESCRIPTION | ||
configure.ac | ||
configure | ||
delete-branch: true # NOTE: No immediate delete after merge, instead branches with no diff are deleted | ||
title: Release version ${{ steps.release_version.outputs.version }} | ||
body: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!