Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory-check in "slow" release cycle #87

Merged
merged 9 commits into from
May 2, 2024

Conversation

j-i-l
Copy link
Collaborator

@j-i-l j-i-l commented Apr 30, 2024

Closes #26

Decision

Since the memory tracking check will most likely exceed the 6h threshold, we cannot simply rely on the free GH runners and need to establish another option.
For the time being we will simply implement an placeholder job that we can correctly integrate into #81 and set up a more complete memory checking workflow, including also furrer-lab/r-containers#29, afterwards.

@j-i-l j-i-l self-assigned this Apr 30, 2024
@j-i-l j-i-l linked an issue Apr 30, 2024 that may be closed by this pull request
@j-i-l
Copy link
Collaborator Author

j-i-l commented Apr 30, 2024

For now these checks run with gctorture and valgrind enabled, however, we might get better results if we use an environment in which R was configured especially for memory checking > see furrer-lab/r-containers#29 (comment)

As far as I understand, we might just switch the container once we have one that is dedicated for memory checking.
I'd handle switching the container in another issue then and focus in this one on the inclusion of the checks suggested in the R docs

@j-i-l
Copy link
Collaborator Author

j-i-l commented Apr 30, 2024

https://drmemory.org seems to be an interesting alternative to valgrind.

To use it we would need to compile abn with -g -fno-inline -fno-omit-frame-pointer, have the drmemory binary installed and run

drmemory R CMD check  # or similar

@j-i-l
Copy link
Collaborator Author

j-i-l commented Apr 30, 2024

... let's see how long these tests run.

We might want to run them only on single occasions if they run for several hours. It might easily happen that we have several commits on a release branch.

@j-i-l j-i-l mentioned this pull request Apr 30, 2024
26 tasks
@j-i-l
Copy link
Collaborator Author

j-i-l commented May 1, 2024

Release Cycle Checks exceeded the 6h limit. ☹️ running with gctorture only now.

@j-i-l
Copy link
Collaborator Author

j-i-l commented May 2, 2024

On option might be to run build with the flags, export the .tar.gz as artifact and then run use a matrix strategy for each file in tests/thestthat/, install abn and run devtools::test_file as we do now with the single example.

@j-i-l
Copy link
Collaborator Author

j-i-l commented May 2, 2024

Memory checks fail successfully! 👍

@j-i-l j-i-l marked this pull request as ready for review May 2, 2024 15:00
@j-i-l j-i-l merged commit d18b681 into main May 2, 2024
1 of 13 checks passed
@j-i-l j-i-l deleted the 26-tests-tracking-memory-usage-the-slow-pipeline branch May 2, 2024 15:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests tracking memory usage (the slow pipeline)
1 participant