Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<=1.1.0: LTO type mismatch #1056

Open
Kangie opened this issue Aug 17, 2024 · 2 comments
Open

<=1.1.0: LTO type mismatch #1056

Kangie opened this issue Aug 17, 2024 · 2 comments
Labels
type:bug Something's broken!

Comments

@Kangie
Copy link
Contributor

Kangie commented Aug 17, 2024 •
edited
Loading

Upfront Information

Please provide the following information by running the command and providing
the output.

1.1.0 on Gentoo Linux

Expected Behaviour

CFLAGS="-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing"
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --datarootdir=/usr/share --disable-dependency-tracking --disable-silent-rules --docdir=/usr/share/doc/fvwm3-1.1.0-r1 --htmldir=/usr/share/doc/fvwm3-1.1.0-r1/html --libdir=/usr/lib64 --with-imagepath=/usr/include/X11/bitmaps:/usr/include/X11/pixmaps:/usr/share/icons/fvwm --enable-package-subdirs --disable-bidi --enable-golang --enable-nls --enable-iconv --disable-perllib --with-readline-library --enable-rsvg --enable-png --disable-mandoc --disable-htmldoc --without-termcap-library
make -j
.  .  .

Actual Behaviour

../libs/Colorset.h:86:20: error: type of ‘Colorset’ does not match original declaration [-Werror=lto-type-mismatch]
   86 | extern colorset_t *Colorset;
      |                    ^
../libs/Colorset.c:36:13: note: ‘Colorset’ was previously declared here
   36 | colorset_t *Colorset = NULL;
      |             ^
../libs/Colorset.c:36:13: note: code may be misoptimized unless ‘-fno-strict-aliasing’ is used
lto1: some warnings being treated as errors
lto-wrapper: fatal error: x86_64-pc-linux-gnu-gcc returned 1 exit status
compilation terminated.
/usr/lib/gcc/x86_64-pc-linux-gnu/14/../../../../x86_64-pc-linux-gnu/bin/ld: error: lto-wrapper failed

Steps to Reproduce

  • Build with the CFLAGS above.

This is fixed in the meson build PR: 5215ec2

See Also:

https://bugs.gentoo.org/864959
@Kangie Kangie added the type:bug Something's broken! label Aug 17, 2024
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 17, 2024
@Kangie
Add additional CI pipelines
972764b 
- Gentoo Linux GCC and Clang (via gentoo/stage3:nomultilib)
- GCC LTO (via fvwmorg/fvwm3-build)

While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 17, 2024
@Kangie
Add additional CI pipelines
c1171c9 
- Gentoo Linux GCC and Clang (via gentoo/stage3:nomultilib)
- GCC LTO (via fvwmorg/fvwm3-build)

While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 17, 2024
@Kangie
Add additional CI pipelines
9060b43 
- Gentoo Linux GCC and Clang (via gentoo/stage3:nomultilib)
- GCC LTO (via fvwmorg/fvwm3-build)

While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 17, 2024
@Kangie
Add additional CI pipelines
a661eb4 
- Gentoo Linux GCC and Clang (via gentoo/stage3:nomultilib)
- GCC LTO (via fvwmorg/fvwm3-build)

While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
@ThomasAdam
Copy link
Member

I'm very much aware of this, but the work we're doing with Meson should help.

That being said, seeing as we'll be supporting both meson and autotools side-by-side, is there anything we need to consider here for autotools?

@Kangie
Copy link
Contributor Author

Kangie commented Aug 21, 2024

AFAIK, no; there's no build system changes for LTO - that's all in compiler / CFLAGS territory.

All we really need is one (or more) CI runs that attempt LTO with the warning flags to pick up any other occurrences ( I don't believe that there are any, this should just prevent it happening again in the future).

Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
Add additional CI pipelines
bf43838 
- Gentoo Linux GCC and Clang (via gentoo/stage3:nomultilib)
- GCC LTO (via fvwmorg/fvwm3-build)

While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
Add additional CI pipelines
87598a8 
- Gentoo Linux GCC and Clang (via gentoo/stage3:nomultilib)
- GCC LTO (via fvwmorg/fvwm3-build)

While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
Add additional CI pipelines
a24591c 
- Gentoo Linux GCC and Clang (via gentoo/stage3:nomultilib)
- GCC LTO (via fvwmorg/fvwm3-build)

While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
Add additional CI pipelines
35e51cf 
- Gentoo Linux GCC and Clang (via gentoo/stage3:nomultilib)
- GCC LTO (via fvwmorg/fvwm3-build)

While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
CI/CD: Add LTO options to GCC build
bc800e2 
While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
CI/CD: Add LTO options to GCC build
3ab7d6a 
While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
CI/CD: Add LTO options to GCC build
68d2349 
While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
CI/CD: Add LTO options to GCC build
43af50a 
While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
CI/CD: Add LTO options to GCC build
87b4b9d 
While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
CI/CD: Add LTO options to GCC build
1a24514 
While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Aug 22, 2024
@Kangie
CI/CD: Add LTO options to GCC build
3a935f0 
While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 16, 2024
@Kangie @ThomasAdam
CI: Update for meson build
d70cbf8 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warningsthat our traditional
autotools + GCC builds might miss.

This commit changes the autotools build to be more like the
meson build path: We no longer build a docker image, rather
directly executing the fvwm3-build container as a github
action.

Factor out the GH Actions steps into a common set, and use them
as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 16, 2024
@Kangie @ThomasAdam
CI: Update for meson build
8cf7ae7 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warningsthat our traditional
autotools + GCC builds might miss.

This commit changes the autotools build to be more like the
meson build path: We no longer build a docker image, rather
directly executing the fvwm3-build container as a github
action.

Factor out the GH Actions steps into a common set, and use them
as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 16, 2024
@Kangie @ThomasAdam
CI: Update for meson build
cbab8a4 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warningsthat our traditional
autotools + GCC builds might miss.

This commit changes the autotools build to be more like the
meson build path: We no longer build a docker image, rather
directly executing the fvwm3-build container as a github
action.

Factor out the GH Actions steps into a common set, and use them
as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 16, 2024
@Kangie @ThomasAdam
CI: Update for meson build
29e5616 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warningsthat our traditional
autotools + GCC builds might miss.

This commit changes the autotools build to be more like the
meson build path: We no longer build a docker image, rather
directly executing the fvwm3-build container as a github
action.

Factor out the GH Actions steps into a common set, and use them
as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 17, 2024
@Kangie @ThomasAdam
CI: Update for meson build
2327ea8 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warningsthat our traditional
autotools + GCC builds might miss.

This commit changes the autotools build to be more like the
meson build path: We no longer build a docker image, rather
directly executing the fvwm3-build container as a github
action.

Factor out the GH Actions steps into a common set, and use them
as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 17, 2024
@Kangie @ThomasAdam
CI: Update for meson build
fe5599b 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warningsthat our traditional
autotools + GCC builds might miss.

This commit changes the autotools build to be more like the
meson build path: We no longer build a docker image, rather
directly executing the fvwm3-build container as a github
action.

Factor out the GH Actions steps into a common set, and use them
as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 18, 2024
@Kangie
CI/CD: Add LTO options to GCC build
c0b6a33 
While the issue with LTO builds has been resolved in this PR, it was
incidental and we should introduce a CI pipeline that will catch
LTO errors before they make it into a release.

Closes: fvwmorg#1056
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 18, 2024
@Kangie @ThomasAdam
CI: Update for meson build
a6fd56d 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warningsthat our traditional
autotools + GCC builds might miss.

This commit changes the autotools build to be more like the
meson build path: We no longer build a docker image, rather
directly executing the fvwm3-build container as a github
action.

Factor out the GH Actions steps into a common set, and use them
as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 18, 2024
@Kangie @ThomasAdam
CI: Update for meson build
3b60ec4 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warnings that our
traditional autotools + GCC builds might miss.

We no longer build a docker image, instead we directly
execute the fvwm3-build container as a GitHub Action.
GH Actions have been factored out into a common set, and are
used as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 18, 2024
@Kangie @ThomasAdam
CI: Update for meson build
fe430b4 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warnings that our
traditional autotools + GCC builds might miss.

We no longer build a docker image, instead we directly
execute the fvwm3-build container as a GitHub Action.
GH Actions have been factored out into a common set, and are
used as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 18, 2024
@Kangie @ThomasAdam
CI: Update for meson build
5dbbb9c 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warnings that our
traditional autotools + GCC builds might miss.

We no longer build a docker image, instead we directly
execute the fvwm3-build container as a GitHub Action.
GH Actions have been factored out into a common set, and are
used as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Kangie added a commit to Kangie/fvwm3 that referenced this issue Sep 18, 2024
@Kangie @ThomasAdam
CI: Update for meson build
33adf3e 
We now include a Meson build that uses Clang + lld as
the build system to catch bugs and warnings that our
traditional autotools + GCC builds might miss.

We no longer build a docker image, instead we directly
execute the fvwm3-build container as a GitHub Action.
GH Actions have been factored out into a common set, and are
used as a matrix set to apply to Ubuntu (glibc) and Alpine (musl).

The Go version in fvwm3-build has been updated to enable use
with meson and eliminate the need for a complex envvar setup
and invocation, however older golang is still supported (>=1.14);
we're just relying on users to tell us if something is broken.

While the issue with LTO builds has been resolved in this PR, it was
incidental and the introduced changes will catch LTO errors before
they make it into a release.

Closes: fvwmorg#1056
Co-authored-by: Thomas Adam <thomas@fvwm.org>
Signed-off-by: Matt Jolly <Kangie@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something's broken!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThomasAdam @Kangie