Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to Nuxt 3 #283

Merged
merged 24 commits into from
Nov 9, 2022
Merged

feat: upgrade to Nuxt 3 #283

merged 24 commits into from
Nov 9, 2022

Conversation

zuramai
Copy link
Collaborator

@zuramai zuramai commented Nov 5, 2022 •
edited
Loading

Description

In progress migrating this Nuxt 2 repo to Nuxt 3.

Closes #161 #246

Todos

  • Use TypeScript
  • Use pinia
  • Fix client library error (need adjustment to use in Nuxt 3)
  • Update README
  • Migrating to Composition API <script setup>

This was referenced Nov 6, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@fzn0x fzn0x added the funded label Nov 6, 2022
@fzn0x fzn0x self-requested a review November 6, 2022 02:24
@fzn0x fzn0x added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 6, 2022
@fzn0x
Copy link
Owner

fzn0x commented Nov 6, 2022

Can you also take a look npm audit and help me to fix any vulnerable dependencies if possible?

This was referenced Nov 6, 2022
Closed
Closed
@fzn0x fzn0x added this to the v2 milestone Nov 6, 2022
This was linked to issues Nov 6, 2022
Multiple issues #161
Closed
npm build not working #246
Closed
fzn0x added a commit that referenced this pull request Nov 6, 2022
@fzn0x
chore: initial pull request template
c129616 
Follow #283 for the initial template
@zuramai zuramai marked this pull request as ready for review November 8, 2022 00:41
zuramai and others added 5 commits November 8, 2022 20:21
@zuramai
chore: remove unused dependencies
4ffa095
@zuramai
fix: sidebar missing after changing page
a9ccbd6
@nimdeveloper
Fix vertical layout problems (#287)
7f04130 
* fix: remove extra sidebar div

* style: remove left margin with vertical layout

* feat: add burger button functionality
@nimdeveloper @fzn0x
fix: sidebar backdrop (#285)
5d71ca8 
Co-authored-by: Fauzan <fncolon@pm.me>
@zuramai
fix: bootstrap js not working
9984334
fzn0x
fzn0x reviewed Nov 8, 2022
View reviewed changes
assets/scss/components/_navbar.scss Show resolved Hide resolved
assets/scss/components/_navbar.scss Show resolved Hide resolved
assets/scss/components/_navbar.scss Show resolved Hide resolved
assets/scss/components/_sidebar.scss Show resolved Hide resolved
assets/scss/components/_sidebar.scss Show resolved Hide resolved
@zuramai
Copy link
Collaborator Author

zuramai commented Nov 9, 2022 •
edited
Loading

Hi @fzn0x, I think the issues you are addressing in the review is probably better to be fixed in the original Mazer repository, and then we can update this repo afterwards. For the rest, what do you think could be improved for the Nuxt side?

@fzn0x
Copy link
Owner

fzn0x commented Nov 9, 2022

Hi @fzn0x, I think the issues you are addressing in the review is probably better to be fixed in the original Mazer repository, and then we can update this repo afterwards. For the rest, what do you think could be improved for the Nuxt side?

Makes sense, looks good to me

@fzn0x fzn0x merged commit 6086435 into main Nov 9, 2022
@fzn0x fzn0x deleted the nuxt3 branch November 9, 2022 02:09
@fzn0x fzn0x mentioned this pull request Nov 9, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzn0x fzn0x fzn0x approved these changes

Assignees

@zuramai zuramai

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request funded typescript
Projects
None yet
Milestone
v2.x.x Major Release
Development

Successfully merging this pull request may close these issues.

npm build not working Multiple issues
3 participants
@zuramai @fzn0x @nimdeveloper