Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetics - no code behaviour changes #397

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Cosmetics - no code behaviour changes #397

merged 3 commits into from
Jun 5, 2023

Conversation

gabriel-vasile
Copy link
Owner

  • Update some comments to the latest formatting rules introduced in go v1.19
  • Revert to ioutil.ReadAll to avoid breaking the library for go v1.16 or lower users

While go 1.16 is 2 years old, I feel like I should not go out of my way
to break the library for users on go versions lower that 1.16. This
commit reverts part of the changes from #392.
The mistake was introduced in a merge commit.
@codecov-commenter
Copy link

Codecov Report

Merging #397 (29d8fab) into master (2352868) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files           3        3           
  Lines         159      159           
=======================================
  Hits          151      151           
  Misses          6        6           
  Partials        2        2           
Impacted Files Coverage Δ
mimetype.go 94.82% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gabriel-vasile gabriel-vasile merged commit c9ecfdd into master Jun 5, 2023
@gabriel-vasile gabriel-vasile deleted the cosmetics branch June 5, 2023 13:19
gabriel-vasile added a commit that referenced this pull request Oct 10, 2023
* Revert ioutil deprecation commit

While go 1.16 is 2 years old, I feel like I should not go out of my way
to break the library for users on go versions lower that 1.16. This
commit reverts part of the changes from #392.

* fix some doc comments for go v1.19 rules

* Fix wrong total number of supported mimes

The mistake was introduced in a merge commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants