remove exe from testdata #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After considering #550 and #551, there seems it's hard to create a windows executable that satisfies these 2 conditions: - is small in size - does not trigger antivirus alerts; seems like many antiviruses just don't care what's inside an exe. If it's .exe then it's a virus. Looking back on it, adding fixture files is not perfect: seems nice to have the library tests work with real files, but: - it does not count towards test-coverage - real files increase repo size Going forward I think I will remove more and more of the files in testdata folder, and add more unit tests.
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After considering #550 and #551, it seems it's hard to create a windows executable that satisfies these 2 conditions:
But it's not all on the antiviruses. Looking back on it, adding fixture files is not perfect: seems nice to have the library tests work with real files, but:
Going forward I think I will remove more and more of the files in testdata folder, and add more unit tests.