Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial ONNX support #13

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

initial ONNX support #13

wants to merge 8 commits into from

Conversation

Hoeze
Copy link

@Hoeze Hoeze commented May 19, 2023

The prediction results do not match yet, see interpretml/ebm2onnx#8

@Hoeze Hoeze marked this pull request as ready for review August 9, 2023 17:36
@Hoeze
Copy link
Author

Hoeze commented Aug 9, 2023

@WagnerNils Can you merge this please?
This converts your models to ONNX and removes the need to install any interpret package for pure inference.

Fun fact:
Did you know that "splice_site_is_expressed" in your EBM gets converted from int -> float -> string -> int?
E.g. splice_site_is_expressed == 1 (int) -> 1.0 (float) -> "1.0" (string) -> 0 (int) 🤦
I manually fixed this in the onnx models using onnx-modifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant