bug fix #21
Open
bug fix #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bug is real, thanks for the PR! |
stefanches7
requested changes
Dec 4, 2019
|
|
||
|
|
||
| wbuildPath = pathlib.Path(wbuild.__file__).parent | ||
| shutil.copytree(str(wbuildPath) + "/html/lib", libDir) ### quick fix for line below |
There was a problem hiding this comment.
should be just htmlOutputPath + '/lib' instead of wbuildPath + "/html/lib"
There was a problem hiding this comment.
I don't think that's correct, since we want to copy from wbuildPath/.. to libDir (= htmlOutputPath + "/lib")
| #fill the HTML template with the constructed tag structure | ||
| wbuildPath = pathlib.Path(wbuild.__file__).parent | ||
|
|
||
| template = open(str(wbuildPath / "template.html")).read() | ||
| template = open(str(wbuildPath / "html/template.html")).read() |
|
These changes are already included in the latest version of wBuild, and they seem to be fully functional, so this PR can be closed. @kTakumo @andradesalazar @stefanches7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index was not created because of small path error and copy error for /lib dir